pleroma/pleroma
4
6
Fork 10
Code Issues 719 Pull requests 81 Projects Releases 1 Packages Wiki Activity

Fix preferred frontends #7911

Open
phnt wants to merge 6 commits from phnt/pleroma:fix-preferred-frontend into develop
pull from: phnt/pleroma:fix-preferred-frontend
merge into: pleroma:develop
Conversation 2 Commits 6 Files changed 8 +128 -74
phnt commented 2026-05-22 17:16:33 +00:00
Owner
Copy link

After InstanceStatic plug was modified to return 404 on missing static media instead of returning FE, preferred frontends stopped working. This moves the missing static media logic into a separate plug at the end of the static chain.

Checklist

  • Adding a changelog: In the changelog.d directory, create a file named <code>.<type>.

Closes #7922

After InstanceStatic plug was modified to return 404 on missing static media instead of returning FE, preferred frontends stopped working. This moves the missing static media logic into a separate plug at the end of the static chain. ### Checklist - [x] Adding a changelog: In the `changelog.d` directory, create a file named `<code>.<type>`. <!-- `<code>` can be anything, but we recommend using a more or less unique identifier to avoid collisions, such as the branch name. `<type>` can be `add`, `change`, `remove`, `fix`, `security` or `skip`. `skip` is only used if there is no user-visible change in the PR (for example, only editing comments in the code). Otherwise, choose a type that corresponds to your change. In the file, write the changelog entry. For example, if a PR adds group functionality, we can create a file named `group.add` and write `Add group functionality` in it. If one changelog entry is not enough, you may add more. But that might mean you can split it into two PRs. Only use more than one changelog entry if you really need to (for example, when one change in the code fix two different bugs, or when refactoring). --> Closes #7922
StaticNotFoundPlug: Move 404 on non-existing static files to a new plug
Some checks failed
ci/woodpecker/pr/changelog Pipeline failed
Details
ci/woodpecker/pr/lint Pipeline failed
Details
ci/woodpecker/pr/unit-testing-elixir-1.18 unknown status
Details
ci/woodpecker/pr/unit-testing-elixir-1.15 unknown status
Details
f6cda465e1
 
This fixes preferred frontends not working (returning 404 on most static
frontend files).
phnt force-pushed fix-preferred-frontend from f6cda465e1
Some checks failed
ci/woodpecker/pr/changelog Pipeline failed
Details
ci/woodpecker/pr/lint Pipeline failed
Details
ci/woodpecker/pr/unit-testing-elixir-1.18 unknown status
Details
ci/woodpecker/pr/unit-testing-elixir-1.15 unknown status
Details
to 3373d90a1d
Some checks failed
ci/woodpecker/pr/changelog Pipeline failed
Details
ci/woodpecker/pr/lint Pipeline was successful
Details
ci/woodpecker/pr/unit-testing-elixir-1.18 Pipeline was canceled
Details
ci/woodpecker/pr/unit-testing-elixir-1.15 Pipeline was canceled
Details
2026-05-23 22:57:26 +00:00 Compare
phnt force-pushed fix-preferred-frontend from 3373d90a1d
Some checks failed
ci/woodpecker/pr/changelog Pipeline failed
Details
ci/woodpecker/pr/lint Pipeline was successful
Details
ci/woodpecker/pr/unit-testing-elixir-1.18 Pipeline was canceled
Details
ci/woodpecker/pr/unit-testing-elixir-1.15 Pipeline was canceled
Details
to 20d05f1a3f
All checks were successful
ci/woodpecker/pr/changelog Pipeline was successful
Details
ci/woodpecker/pr/lint Pipeline was successful
Details
ci/woodpecker/pr/unit-testing-elixir-1.15 Pipeline was successful
Details
ci/woodpecker/pr/unit-testing-elixir-1.18 Pipeline was successful
Details
2026-05-23 23:03:23 +00:00 Compare
StaticNotFoundPlug: Remove unused plug options
Some checks failed
ci/woodpecker/pr/changelog Pipeline was successful
Details
ci/woodpecker/pr/lint Pipeline was successful
Details
ci/woodpecker/pr/unit-testing-elixir-1.15 Pipeline was successful
Details
ci/woodpecker/pr/unit-testing-elixir-1.18 Pipeline was canceled
Details
76c5953df1
phnt changed title from WIP: Fix preferred frontends to Fix preferred frontends 2026-06-01 19:34:36 +00:00
hj commented 2026-06-01 19:35:24 +00:00
Owner
Copy link

#7922 might be related?

https://git.pleroma.social/pleroma/pleroma/issues/7922 might be related?
phnt commented 2026-06-01 19:35:27 +00:00
Author
Owner
Copy link

Note: The last Plug.Static call at "/" is still needed. Without it the TOS override and cache header tests fail.

Note: The last Plug.Static call at "/" is still needed. Without it the TOS override and cache header tests fail.
InstanceStaticPlug: Add more override and fallback tests
Some checks failed
ci/woodpecker/pr/lint Pipeline is pending
Details
ci/woodpecker/pr/unit-testing-elixir-1.15 Pipeline is pending
Details
ci/woodpecker/pr/unit-testing-elixir-1.18 Pipeline is pending
Details
ci/woodpecker/pr/changelog Pipeline was canceled
Details
3c66aad51b
phnt force-pushed fix-preferred-frontend from 3c66aad51b
Some checks failed
ci/woodpecker/pr/lint Pipeline is pending
Details
ci/woodpecker/pr/unit-testing-elixir-1.15 Pipeline is pending
Details
ci/woodpecker/pr/unit-testing-elixir-1.18 Pipeline is pending
Details
ci/woodpecker/pr/changelog Pipeline was canceled
Details
to ac25af7b29
Some checks failed
ci/woodpecker/pr/unit-testing-elixir-1.18 Pipeline is pending
Details
ci/woodpecker/pr/lint Pipeline was successful
Details
ci/woodpecker/pr/docker-armv7 Pipeline was canceled
Details
ci/woodpecker/pr/changelog Pipeline was canceled
Details
ci/woodpecker/pr/unit-testing-elixir-1.15 Pipeline was canceled
Details
2026-06-01 19:55:32 +00:00 Compare
phnt force-pushed fix-preferred-frontend from ac25af7b29
Some checks failed
ci/woodpecker/pr/unit-testing-elixir-1.18 Pipeline is pending
Details
ci/woodpecker/pr/lint Pipeline was successful
Details
ci/woodpecker/pr/docker-armv7 Pipeline was canceled
Details
ci/woodpecker/pr/changelog Pipeline was canceled
Details
ci/woodpecker/pr/unit-testing-elixir-1.15 Pipeline was canceled
Details
to 6ec30bbba2
Some checks failed
ci/woodpecker/pr/lint Pipeline was successful
Details
ci/woodpecker/pr/unit-testing-elixir-1.15 Pipeline was successful
Details
ci/woodpecker/pr/changelog Pipeline was canceled
Details
ci/woodpecker/pr/unit-testing-elixir-1.18 Pipeline was canceled
Details
2026-06-01 20:00:58 +00:00 Compare
phnt force-pushed fix-preferred-frontend from 6ec30bbba2
Some checks failed
ci/woodpecker/pr/lint Pipeline was successful
Details
ci/woodpecker/pr/unit-testing-elixir-1.15 Pipeline was successful
Details
ci/woodpecker/pr/changelog Pipeline was canceled
Details
ci/woodpecker/pr/unit-testing-elixir-1.18 Pipeline was canceled
Details
to a71ee6c86a
All checks were successful
ci/woodpecker/pr/changelog Pipeline was successful
Details
ci/woodpecker/pr/lint Pipeline was successful
Details
ci/woodpecker/pr/unit-testing-elixir-1.15 Pipeline was successful
Details
ci/woodpecker/pr/unit-testing-elixir-1.18 Pipeline was successful
Details
ci/woodpecker/pr/docker-armv7 Pipeline was successful
Details
2026-06-02 07:17:28 +00:00 Compare
All checks were successful
ci/woodpecker/pr/changelog Pipeline was successful
Details
ci/woodpecker/pr/lint Pipeline was successful
Details
ci/woodpecker/pr/unit-testing-elixir-1.15 Pipeline was successful
Details
ci/woodpecker/pr/unit-testing-elixir-1.18 Pipeline was successful
Details
ci/woodpecker/pr/docker-armv7 Pipeline was successful
Details
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u fix-preferred-frontend:phnt-fix-preferred-frontend
git switch phnt-fix-preferred-frontend

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch develop
git merge --no-ff phnt-fix-preferred-frontend
git switch phnt-fix-preferred-frontend
git rebase develop
git switch develop
git merge --ff-only phnt-fix-preferred-frontend
git switch phnt-fix-preferred-frontend
git rebase develop
git switch develop
git merge --no-ff phnt-fix-preferred-frontend
git switch develop
git merge --squash phnt-fix-preferred-frontend
git switch develop
git merge --ff-only phnt-fix-preferred-frontend
git switch develop
git merge phnt-fix-preferred-frontend
git push origin develop
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
AP C2S

   
AdminAPI

   
Breaking API
Affects clients

  
Breaks existing config

   
Check if still valid

   
Data Protection

   
Do not merge

   
Document in the changelog

   
Doing

   
Feature Request / Enhancement

   
MastoAPI

   
NL2
Improved Mobile Experience

  
NL4
Improved instance customization and QoL options

  
OStatus

   
OTP Releases

   
Refactor

   
Security

   
To Do

   
TwitterAPI

   
bug

   
complicated

   
confirmed

   
deps

   
discussion

   
documentation

   
easy

   
feature: to be merged in stable

   
fix: to be merged in stable

   
incident
Denotes a disruption to IT services and the associated issues require immediate attention

  
needs to be backported to maint

   
needs-changes

   
needs-info

   
needs-review

   
performance

   
regression

   
unclear
No labels
AP C2S
AdminAPI
Breaking API
Breaks existing config
Check if still valid
Data Protection
Do not merge
Document in the changelog
Doing
Feature Request / Enhancement
MastoAPI
NL2
NL4
OStatus
OTP Releases
Refactor
Security
To Do
TwitterAPI
bug
complicated
confirmed
deps
discussion
documentation
easy
feature: to be merged in stable
fix: to be merged in stable
incident
needs to be backported to maint
needs-changes
needs-info
needs-review
performance
regression
unclear
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pleroma/pleroma!7911
No description provided.