pleroma/pleroma
0
1
Fork 2
Code Issues 771 Pull requests 71 Projects Releases Packages Wiki Activity

Add Actor Type and Discoverable preferences #4998

Closed
hakabahitoyo wants to merge 9 commits from gitlab-mr-iid-1616 into develop
pull from: gitlab-mr-iid-1616
merge into: pleroma:develop
Conversation 6 Commits 9 Files changed 7 +35 -9
hakabahitoyo commented 2019-08-31 13:16:44 +00:00
Member
Copy link

In Pleroma-FE: pleroma/pleroma-fe#2202.

This MR suggests to add 2 parameters type and discoverable in the ActivityPub Actor.

The type parameter has the values Application, Group, Organization, Person, and Service in the ActivityStream Standard. Mastodon only uses Person and Service, the Service is for the bot flag. Now Pleroma sends only Person.

The discoverable parameter is the opt-in signal which allows to show a user in the Mastodon's profile directory. Pleroma has not profile directory yet, but Mastodon's profile directory is showing federated (external) users. If a Pleroma user sends discoverable: true via ActivityPub, the user is shown in some Mastodon instance's profile directory.

In Pleroma-FE: https://git.pleroma.social/pleroma/pleroma-fe/pulls/2202. This MR suggests to add 2 parameters `type` and `discoverable` in the ActivityPub Actor. The `type` parameter has the values `Application`, `Group`, `Organization`, `Person`, and `Service` in the [ActivityStream Standard](https://www.w3.org/TR/activitystreams-vocabulary/#actor-types). Mastodon only uses `Person` and `Service`, the `Service` is for the _bot_ flag. Now Pleroma sends only `Person`. The `discoverable` parameter is the opt-in signal which allows to show a user in the Mastodon's _profile directory_. Pleroma has not profile directory yet, but [Mastodon's profile directory is showing federated (external) users](https://github.com/tootsuite/mastodon/pull/11688). If a Pleroma user sends `discoverable: true` via ActivityPub, the user is shown in some Mastodon instance's profile directory.
kaniini commented 2019-08-31 17:17:34 +00:00
Member
Copy link

what does the discoverable preference do, other than break federation with Mastodon? ;)

what does the discoverable preference do, other than break federation with Mastodon? ;)
rinpatch commented 2019-08-31 17:19:44 +00:00
Member
Copy link

we should not use source_data outside of migrations, actor type should be parsed from remote users as well

we should not use `source_data` outside of migrations, actor type should be parsed from remote users as well
rinpatch commented 2019-08-31 17:27:21 +00:00
Member
Copy link

Where did this come from and why is this needed? I don't see such property neither in mastodon responses nor in the specs

Where did this come from and why is this needed? I don't see such property neither in mastodon responses nor in the specs
hakabahitoyo commented 2019-09-01 16:42:11 +00:00
Author
Member
Copy link

This is a new feature of Mastodon which was merged into master on Aug 30. It is available in https://mastodon.social now. See also Mastodon's PR #11668.

This is a new feature of Mastodon which was merged into `master` on Aug 30. It is available in https://mastodon.social now. See also [Mastodon's PR #11668](https://github.com/tootsuite/mastodon/pull/11688).
hakabahitoyo commented 2019-09-01 16:46:51 +00:00
Author
Member
Copy link

If we send discoverable: true, the Mastodon's profile directory shows us via federation.

If we send `discoverable: true`, the Mastodon's _profile directory_ shows us via federation.
hakabahitoyo commented 2019-09-07 13:31:18 +00:00
Author
Member
Copy link

I'm closing this MR for focusing only discoverable parameter in #5023.

I'm closing this MR for focusing only `discoverable` parameter in #5023.

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
AP C2S

   
AdminAPI

   
Breaking API

Affects clients

  
Breaks existing config

   
Check if still valid

   
Data Protection

   
Do not merge

   
Document in the changelog

   
Doing

   
Feature Request / Enhancement

   
MastoAPI

   
NL2

Improved Mobile Experience

  
NL4

Improved instance customization and QoL options

  
OStatus

   
OTP Releases

   
Refactor

   
Security

   
To Do

   
TwitterAPI

   
bug

   
complicated

   
confirmed

   
deps

   
discussion

   
documentation

   
easy

   
feature: to be merged in stable

   
fix: to be merged in stable

   
incident

Denotes a disruption to IT services and the associated issues require immediate attention

  
needs to be backported to maint

   
needs-changes

   
needs-info

   
needs-review

   
performance

   
regression

   
unclear
No labels
AP C2S
AdminAPI
Breaking API
Breaks existing config
Check if still valid
Data Protection
Do not merge
Document in the changelog
Doing
Feature Request / Enhancement
MastoAPI
NL2
NL4
OStatus
OTP Releases
Refactor
Security
To Do
TwitterAPI
bug
complicated
confirmed
deps
discussion
documentation
easy
feature: to be merged in stable
fix: to be merged in stable
incident
needs to be backported to maint
needs-changes
needs-info
needs-review
performance
regression
unclear
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pleroma/pleroma!4998
No description provided.